diff --git a/src/mapblock.cpp b/src/mapblock.cpp index 1d2e1e2501f0b79bc989f0aab20252b24248cd7b..43057f3a54fc5ece599d870bf098249bd3d65052 100644 --- a/src/mapblock.cpp +++ b/src/mapblock.cpp @@ -69,6 +69,7 @@ static const char *modified_reason_strings[] = { MapBlock::MapBlock(Map *parent, v3s16 pos, IGameDef *gamedef, bool dummy): m_parent(parent), m_pos(pos), + m_pos_relative(pos * MAP_BLOCKSIZE), m_gamedef(gamedef), m_modified(MOD_STATE_WRITE_NEEDED), m_modified_reason(MOD_REASON_INITIAL), diff --git a/src/mapblock.h b/src/mapblock.h index 92ca4b485f5fc1c5826b5ca54d005655b45a91b8..ba33c01a2eef145f24803241c795de1f31d3ea56 100644 --- a/src/mapblock.h +++ b/src/mapblock.h @@ -258,7 +258,7 @@ class MapBlock /*: public NodeContainer*/ inline v3s16 getPosRelative() { - return m_pos * MAP_BLOCKSIZE; + return m_pos_relative; } inline core::aabbox3d<s16> getBox() @@ -564,6 +564,14 @@ class MapBlock /*: public NodeContainer*/ // Position in blocks on parent v3s16 m_pos; + /* This is the precalculated m_pos_relative value + * This caches the value, improving performance by removing 3 s16 multiplications + * at runtime on each getPosRelative call + * For a 5 minutes runtime with valgrind this removes 3 * 19M s16 multiplications + * The gain can be estimated in Release Build to 3 * 100M multiply operations for 5 mins + */ + v3s16 m_pos_relative; + IGameDef *m_gamedef; /*