From 2b7ca68805adb59bd56aab6735c77cb8ad20abc5 Mon Sep 17 00:00:00 2001
From: PilzAdam <pilzadam@minetest.net>
Date: Sun, 7 Dec 2014 12:23:43 +0100
Subject: [PATCH] Cleanup * Remove unused variables * Fix wearing out of
screwdriver * Move magic numbers into constants * Scale down texture
---
mods/screwdriver/init.lua | 23 +++++++++++-----------
mods/screwdriver/textures/screwdriver.png | Bin 286 -> 261 bytes
2 files changed, 11 insertions(+), 12 deletions(-)
diff --git a/mods/screwdriver/init.lua b/mods/screwdriver/init.lua
index 59c00443..4aadaa0a 100644
--- a/mods/screwdriver/init.lua
+++ b/mods/screwdriver/init.lua
@@ -6,6 +6,10 @@ local function nextrange(x, max)
return x
end
+local ROTATE_FACE = 1
+local ROTATE_AXIS = 2
+local USES = 10
+
-- Handles rotation
local function screwdriver_handler(itemstack, user, pointed_thing, mode)
if pointed_thing.type ~= "node" then
@@ -13,8 +17,6 @@ local function screwdriver_handler(itemstack, user, pointed_thing, mode)
end
local pos = pointed_thing.under
- local keys = user:get_player_control()
- local player_name = user:get_player_name()
if minetest.is_protected(pos, user:get_player_name()) then
minetest.record_protection_violation(pos, user:get_player_name())
@@ -34,22 +36,19 @@ local function screwdriver_handler(itemstack, user, pointed_thing, mode)
local n = node.param2
local axisdir = math.floor(n / 4)
local rotation = n - axisdir * 4
- if mode == 1 then
+ if mode == ROTATE_FACE then
n = axisdir * 4 + nextrange(rotation, 3)
- elseif mode == 3 then
+ elseif mode == ROTATE_AXIS then
n = nextrange(axisdir, 5) * 4
end
node.param2 = n
minetest.swap_node(pos, node)
- local item_wear = tonumber(itemstack:get_wear())
- item_wear = item_wear + 300 -- was 327
- if item_wear > 65535 then
- itemstack:clear()
- return itemstack
+ if not minetest.setting_getbool("creative_mode") then
+ itemstack:add_wear(65535 / (USES - 1))
end
- itemstack:set_wear(item_wear)
+
return itemstack
end
@@ -58,11 +57,11 @@ minetest.register_tool("screwdriver:screwdriver", {
description = "Screwdriver (left-click rotates face, right-click rotates axis)",
inventory_image = "screwdriver.png",
on_use = function(itemstack, user, pointed_thing)
- screwdriver_handler(itemstack, user, pointed_thing, 1)
+ screwdriver_handler(itemstack, user, pointed_thing, ROTATE_FACE)
return itemstack
end,
on_place = function(itemstack, user, pointed_thing)
- screwdriver_handler(itemstack, user, pointed_thing, 3)
+ screwdriver_handler(itemstack, user, pointed_thing, ROTATE_AXIS)
return itemstack
end,
})
diff --git a/mods/screwdriver/textures/screwdriver.png b/mods/screwdriver/textures/screwdriver.png
index f471756d4239d51092fb9bbe957a78fe6275b639..33cb83f71a4fa6a4398a84cfe13e0ac49de28137 100644
GIT binary patch
literal 261
zcmeAS@N?(olHy`uVBq!ia0vp^0wB!73?$#)eFPF<EDmyaVpw-h<|UA05a1Ky+8nN-
zC(moGF65#s5@0G3VJQ=9D_P*JoS2YOR@TrzY1-1|D|hbMckSklr?1}p{`<QrZTk_B
zK_x+c!3+-1Zlr-YN#5=*3>~bp9zYIffk$L90|U1(2s1Lwnj--eWH0gbb!ETD!_F-x
ztg%IMJy6Ke)5S4_<9c#J1LM5S2FLcYX7IF4-M@fmU)>A=cApML#gZ6?Q(C1>Mn0FA
v6nK_h30N^9TOy=G)r3Rs2}7!ZAp=7%J6}X<&AshF!x%hW{an^LB{Ts5DT_`#
delta 272
zcmZo=n#bhQ8Q|y6%O%Cdz`(%k>ERLtq!mDzgBeJ=Ea^H1q>KZ6LR>8v81&?Mt<{BG
zbVUM8B_b?kVr?Z0yp@~7H75E=)K3%b@c}AjED7=pW^j0RBMr!z>FMGaVsU!!d2gY^
z3OvjK#~=6$=T!Z_JZ;(KrLN&u!}41cZ>g_4Qk%l#;+A%<$A#PS`5vzckJ*@IHbyS!
zxq5!b1^eTc^BhuKY!)cY+9~`c{-RlvWLLuH!`X$KbQ8YHp7mKHe@FYkx<yIroTp~=
z?q0Fld#7XjttiH(aQ)b<i@WX=ChA-%bILk+KYYf97pgxvF6?hTRL7b2OI1JN2K(LQ
TI~;OAS2B3I`njxgN@xNA4V-3u
--
GitLab