Skip to content
Snippets Groups Projects
  • est31's avatar
    af301831
    Add option to not send pre v25 init packet · af301831
    est31 authored
    The legacy init packet (pre v25) sends information about the client's
    password that a server could use to log in to other servers if the
    username and password are the same. All the other benefits of SRP of
    protocol v25 are missed if the legacy init packet is still sent during
    connection creation.
    
    This patch adds an option to not send the v25 init packet. Not sending
    the v25 packet means breaking compat with pre v25 servers, but as the
    option is not enabled by default, no servers are affected unless the
    user explicitly flips the switch. More than 90% of the servers on the
    serverlist support post v25 protocols.
    
    The patch also fixes a bug with greying out of non compliant servers
    being done wrongly, the min and max params were mixed.
    af301831
    History
    Add option to not send pre v25 init packet
    est31 authored
    The legacy init packet (pre v25) sends information about the client's
    password that a server could use to log in to other servers if the
    username and password are the same. All the other benefits of SRP of
    protocol v25 are missed if the legacy init packet is still sent during
    connection creation.
    
    This patch adds an option to not send the v25 init packet. Not sending
    the v25 packet means breaking compat with pre v25 servers, but as the
    option is not enabled by default, no servers are affected unless the
    user explicitly flips the switch. More than 90% of the servers on the
    serverlist support post v25 protocols.
    
    The patch also fixes a bug with greying out of non compliant servers
    being done wrongly, the min and max params were mixed.