Skip to content
Snippets Groups Projects
  1. Oct 04, 2015
  2. Oct 03, 2015
  3. Oct 02, 2015
  4. Sep 30, 2015
    • est31's avatar
      Fix some SRP issues · 0bf1984d
      est31 authored
      -> Remove memory allocation bugs
      -> Merge changes from upstream, enabling customizeable memory allocation
      0bf1984d
  5. Sep 29, 2015
    • est31's avatar
      Some map border related fixes · 2a7d01b8
      est31 authored
      1. Check for entity addition success in spawn_item implementation
      2. Check for success in item_drop callback, so that the player
      doesn't lose the item if they are outside bounds and try to drop it.
      3. When existing player joins game, check that their position is inside
      map bounds. If not, set their position to the return value of findSpawnPos().
      4. Make findSpawnPos() respect the border
      
      2 fixes a lua crash if a player drops an item outside map bounds.
      3 fixes an assertion crash if a player leaves when being outside map bounds,
      and then rejoins.
      2a7d01b8
    • Kahrl's avatar
      Don't serialize StaticObjectList with > 65535 objects · 0cde0325
      Kahrl authored
      Because the count is serialized as u16, this would cause overflow.
      
      If minetest later deserialized a mapblock with an incorrect
      static object count, it would be unable to find the NameIdMapping
      (which comes after the StaticObjectList) and abort with an error
      such as "Invalid block data in database: unsupported NameIdMapping
      version" (issue #2610).
      0cde0325
  6. Sep 27, 2015
    • paramat's avatar
      Decorations: Remove error message 'chunksize not divisable by sidelen' · ffe291cb
      paramat authored
      Sidelen larger than 16 is essential for low density decorations
      With sidelen > 16 chunksize may not be divisable by sidelen if
      chunksize is changed, in this situation setting sidelen = chunksize
      is desirable and should not create error messages.
      ffe291cb
    • est31's avatar
      Abort at uncatched exceptions · e7282816
      est31 authored
      Change a remaining assert(0) call to FATAL_ERROR(msg).
      There was a regression since commit
      
      ced6d202 "For usages of assert() that are meant to persist in Release builds (when NDEBUG is defined), replace those usages with persistent alternatives"
      
      where when an "uncatched" exception is thrown inside a "side thread",
      the program doesn't abort anymore.
      
      This led to the problem @netinetwalker experienced where the emergethread
      got an unhandled exception for loading a mapblock while redis was loading,
      (see #3196) and then jmped outside its loop to work down its queue.
      This resulted in the server not doing any emerges anymore.
      e7282816
  7. Sep 26, 2015
    • est31's avatar
      Fix redis erroring on non found blocks · 4338f100
      est31 authored
      Thanks to @netinetwalker for spotting the error, proposing a fix, and testing it.
      
      Error due to @est31's merging changes to PR #3202 to add more error reporting for invalid reply types, commit:
      
      524a7656 "redis: throw error if block request failed"
      
      Now we branch out on the valid reply type "not found".
      4338f100
    • Christof Kaufmann's avatar
      Fix falling through nodes on world load (fixes #2784) · 8787d2e7
      Christof Kaufmann authored
      On world load the collision code can not see node boxes, since the
      nodes have not been loaded. Thus it collided only at the next full
      node. However, standing on a slab on world load leaded to sinking into
      it until the world finished loading. Then one maybe fell further, if
      the node below was not walkable.
      
      Now, with this commit, when no node around the player has been loaded
      it simply does not move the player.
      8787d2e7
    • netinetwalker's avatar
      redis: throw error if block request failed · 524a7656
      netinetwalker authored
      Fixes #3196. Before, we didn't throw an error, and the engine thought the
      block isn't occupied. But in fact it might be that redis is still loading,
      and the block does exist in the database. The result was a cheesy map.
      524a7656
  8. Sep 23, 2015
  9. Sep 22, 2015
  10. Sep 19, 2015
  11. Sep 17, 2015
    • est31's avatar
      Send proper block to old clients for swap_node calls · 94f1e5d9
      est31 authored
      The legacy code added in commit
      
      d879a539 - "Add minetest.swap_node"
      
      for sending the whole mapblock to older clients on the case of a node
      modification with swap_node, had the problem that the block chosen to be
      sent to the client was referenced with node coordinates and not with
      block coordinates, resulting in getting the wrong block sent to the client.
      94f1e5d9
    • kwolekr's avatar
      Ore: Add puff ore type · dcbb9533
      kwolekr authored
      dcbb9533
  12. Sep 16, 2015
  13. Sep 15, 2015
    • est31's avatar
      Disallow placing entities outside safe boundaries · f61f817b
      est31 authored
      Entity positions are serialized as F1000. Disallow placing
      entities outside safe borders with the minetest.add_entity
      call.
      
      Note that this patch only enforces those boundaries for
      placing entities, moving entities that move outside boundaries
      aren't affected.
      
      Thanks to @nanepiwo for pointing this out.
      f61f817b
  14. Sep 14, 2015
    • paramat's avatar
      Firelike drawtype: Improve code · 8e9c9e30
      paramat authored
      Remove unusable fine rotation by param2
      Remove unused and redundant code
      Fix code style issues
      8e9c9e30
    • est31's avatar
      Serialisation: documentation fixes, clarifying renames and whitespace fixes · 283bf97a
      est31 authored
      1. Do two renames:
      	* SER_FMT_CLIENT_VER_LOWEST -> SER_FMT_VER_LOWEST_WRITE
      	* SER_FMT_VER_LOWEST -> SER_FMT_VER_LOWEST_READ
      Now the two define values are consistently named with the _WRITE defines
      SER_FMT_VER_{HIGHEST,LOWEST}_WRITE, and to better point out what the two
      serialisation versions actually are for.
      
      2. wrap some lines in doc/worldformat.txt, and point out that the node
      timers are serialized at a later point, as this can cause confusion about
      what now happens (if one doesn't strictly read the if block's conditions).
      
      3. some whitespace fixes in NodeTimerList::serialize, and one new comment.
      283bf97a
  15. Sep 13, 2015
    • kwolekr's avatar
      Ore: Add ore sheet column height range selection · beba9694
      kwolekr authored
      Modders are now able to select the range of ore column height,
      and the midpoint at which they 'grow' starting from.
      This commit adds three new parameters for the 'sheet' ore type:
      column_height_min, column_height_max, and column_midpoint_factor.
      clust_size is now deprecated for this ore type.
      beba9694
  16. Sep 10, 2015
    • est31's avatar
      networkprotocol.h: remove "u16 command" from doc · 64a5eec1
      est31 authored
      Its obvious that "u16 command" is inside every packet, therefore this
      commit removes all mentions of the command, if non-array like notation
      is used. We already didn't add "u16 command" to new packets or removed
      it at packet changes, so now we remove it from existing packets.
      64a5eec1
    • est31's avatar
      Improve locale directory detection · 2a9da62b
      est31 authored
      Use in-place locale directory if that exists, and
      static one (RUN_IN_PLACE or CUSTOM_LOCALEDIR) doesn't exist.
      Report to errorstream if neither static nor in-place locale
      dirs exist, and report successfully found paths to infostreem.
      
      Fixes two bugs:
      
      -> Regression of commit [1] where if we use RUN_IN_PLACE=false,
      	but don't make install, locales aren't found. One might
      	think this is no regression, as its no bug, but all other
      	paths (mainmenu, etc.) are detected properly.
      -> Regression of commit [1] where locales don't work on windows.
      
      References:
      [1]: Commit 645e2086 "Use CUSTOM_LOCALEDIR if specified" by @ShadowNinja
      2a9da62b
  17. Sep 08, 2015
  18. Sep 07, 2015
  19. Sep 06, 2015
  20. Sep 03, 2015
    • est31's avatar
      Areastore: fix "attempt to index a number value" · 2035bfc3
      est31 authored
      Before, calling get_areas_in_area for an areastore with both
      include_borders and include_data would result in a lua error,
      if there was at least one area as result:
      attempt to index a number value in function 'get_areas_in_area'
      2035bfc3
  21. Sep 01, 2015
Loading